Skip to content

Files regarding Baklava update to CR8#9899

Merged
martinvol merged 8 commits intomasterfrom
martinvol/baklavaUpToDateDeploy
Nov 25, 2022
Merged

Files regarding Baklava update to CR8#9899
martinvol merged 8 commits intomasterfrom
martinvol/baklavaUpToDateDeploy

Conversation

@martinvol
Copy link
Copy Markdown
Collaborator

@martinvol martinvol commented Sep 29, 2022

Description

Baklava was stuck in CR3 because it wasn't able to pass governance proposals. One that issue was fixed, a governance proposal was passed to speed run it to CR8 in one go. This is unconventional, as in mainnet Contract Releases go 1-by-1. Thus this will be one of the few proposals on Baklava that are unique, as they didn't pass in any other testnet.

To generate this file, the standard tooling described here was used, but the versions where set accordingly (rather than N+1, using the notation of the documentation). The tooling didn't have any issue processing this.

Note that ExchangeBRL.sol has different arguments than when ExchangeBRL was originally deploy on tesnets and mainnet, that is because this PR was deployed in-between.

Version diff reports and release data are committed in this PR for future reference.

Other changes

N/A

Tested

In Baklava iteself.

Related issues

Backwards compatibility

None

Documentation

The description of this PR itself.

Comment thread packages/protocol/releaseData/nonstandard/baklavaUpdate.json Outdated
Comment thread packages/protocol/releaseData/nonstandard/baklavaUpdate.json Outdated
@martinvol
Copy link
Copy Markdown
Collaborator Author

Pasting the output of check versions here

% yarn check-versions -a core-contracts.v3 -b core-contracts.v8 -r "report_origianl_baklava.json"
yarn run v1.22.17
$ ./scripts/bash/check-versions.sh -a core-contracts.v3 -b core-contracts.v8 -r report_origianl_baklava.json
 - Checkout contracts source code at core-contracts.v3
 - Contract artifacts already built at build/core-contracts.v3
 - Checkout contracts source code at core-contracts.v8
 - Contract artifacts already built at build/core-contracts.v8
 - Checkout migrationsConfig.js at core-contracts.v8
$ /Users/martinvol/celo/celo-monorepo/node_modules/.bin/ts-node scripts/check-backward.ts sem_check --old_contracts build/core-contracts.v3/contracts --new_contracts build/core-contracts.v8/contracts --exclude '.*Test|Mock.*|I[A-Z].*|.*Proxy|MultiSig.*|ReleaseGold|SlasherUtil|UsingPrecompiles' --output_file report_origianl_baklava.json
Running storage report...Done
Running code report...Done
Running library linking...Done
Generating backward report...Done
Writing compatibility report to report_origianl_baklava.json ...Done
Version mismatch detected:
{
    "contracts": {
        "Accounts": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 1,
                "patch": 1
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 4,
                "patch": 0
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "Election": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 1,
                "patch": 0
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 2,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "ExchangeBRL": {
            "oldVersion": null,
            "newVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 0
            },
            "expectedDelta": {
                "storage": "=",
                "major": "+1",
                "minor": "0",
                "patch": "0"
            }
        },
        "Governance": {
            "oldVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 2
            },
            "newVersion": {
                "storage": 1,
                "major": 2,
                "minor": 1,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "GrandaMento": {
            "oldVersion": null,
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 0,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "+1",
                "minor": "0",
                "patch": "0"
            }
        },
        "MetaTransactionWallet": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 0,
                "patch": 1
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 1,
                "patch": 1
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "+1",
                "patch": "0"
            }
        },
        "Reserve": {
            "oldVersion": {
                "storage": 1,
                "major": 1,
                "minor": 2,
                "patch": 0
            },
            "newVersion": {
                "storage": 1,
                "major": 1,
                "minor": 2,
                "patch": 2
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "=",
                "patch": "+1"
            }
        },
        "Validators": {
            "oldVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 0
            },
            "newVersion": {
                "storage": 1,
                "major": 2,
                "minor": 0,
                "patch": 3
            },
            "expectedDelta": {
                "storage": "=",
                "major": "=",
                "minor": "=",
                "patch": "+1"
            }
        }
    }
}

@martinvol martinvol force-pushed the martinvol/baklavaUpToDateDeploy branch from b94ac2a to 913a450 Compare October 12, 2022 20:27
Comment thread packages/protocol/releaseData/nonstandard/baklavaUpdate.json
@martinvol martinvol marked this pull request as ready for review November 24, 2022 15:09
@martinvol martinvol enabled auto-merge (squash) November 24, 2022 16:57
@martinvol martinvol disabled auto-merge November 25, 2022 12:36
@martinvol martinvol merged commit 3e59be1 into master Nov 25, 2022
@martinvol martinvol deleted the martinvol/baklavaUpToDateDeploy branch November 25, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants