Conversation
aaronmgdr
requested review from
asaj,
mcortesi and
timmoreton
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves PhoneNumberUtils and countries.ts, and part of io.ts to this new phone-utils package. the pupose of which is t house functions that depend on the heavey libraries of google-libphonenumber and country-data.js. which are only needed for certain applications but which greatly increase the bundle sizes.
Plan
merge in the new phone-utils packagesOther changes
Tested
includes tests from previous.
Related issues
Backwards compatibility
While this Change is backwards compatible. When we remove the functions that are in this package from @celo/utils that will be a breaking change.
Documentation
Im un clear on what is needed for this.