Adds full verification to combined ODIS signature in Combiner#8992
Merged
Adds full verification to combined ODIS signature in Combiner#8992
Conversation
alecps
requested review from
a team,
codyborn and
nategraf
and removed request for
a team
nategraf
reviewed
Nov 19, 2021
nategraf
reviewed
Nov 19, 2021
…epo into alecps/odisSigVerify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a verification step to ensure the combiner does not return a combined signature that uses invalid partial signatures. Rather than verify each partial signature independently (which incurs high latency), this PR attempts to verify the full combined signature against the ODIS public key.
Other changes
None
Tested
e2e test (signer) and unit test (combiner)
Related issues
NA
Backwards compatibility
Yes
Documentation
None