Skip to content

Fix cip35 test#8939

Merged
mergify[bot] merged 8 commits intomasterfrom
trianglesphere/fix_cip35_e2e_test
Dec 2, 2021
Merged

Fix cip35 test#8939
mergify[bot] merged 8 commits intomasterfrom
trianglesphere/fix_cip35_e2e_test

Conversation

@trianglesphere
Copy link
Copy Markdown
Contributor

Description

This fixes the test to handle some changes in the 1.10.7 geth merge.

Changes

  • Update one error message
  • Accept that all unprotected (wrt. replay protection) transactions are rejected.
  • Don't send the chainId to geth because it's being incorrectly encodded
  • Change the custom transaction creation logic to match what geth expects (no leading zeros with hex numbers).

This fixes the test to handle some changes in the 1.10.7 geth merge.
@trianglesphere trianglesphere requested a review from asaj as a code owner November 5, 2021 21:58
Copy link
Copy Markdown
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify Bot merged commit b8cd02c into master Dec 2, 2021
@mergify mergify Bot deleted the trianglesphere/fix_cip35_e2e_test branch December 2, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants