Add nginx sidecar to geth#8136
Closed
jcortejoso wants to merge 10 commits intomasterfrom
Closed
Conversation
jcortejoso
changed the title
lvpeschke
reviewed
Jun 21, 2021
| maxpeers: 1000 | ||
| serve: 90 | ||
| fullnodeCheckBlockAge: true | ||
| enable_nginx: true |
Contributor
There was a problem hiding this comment.
Could you add a comment for future readers of the file to explain why nginx is added by default?
Comment on lines
+148
to
+149
| params.push(`--set blockscout.jsonrpc_http_url=http://tx-nodes-private:3000/rpc`) | ||
| params.push(`--set blockscout.jsonrpc_ws_url=ws://tx-nodes-private:3000/ws`) |
Contributor
There was a problem hiding this comment.
Is there a way to read these parameters from the environment variables instead of hardcoding them, so that there is a single source of truth for the configuration?
Member
Author
|
Closing in favor of #8161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add nginx sidecar to handle the geth rpc/ws services. Workaround to sessionAffinity not working as expected (celo-blockchain#1600)
Other changes
Describe any minor or "drive-by" changes here.
Tested
Nginx seems to work well. Additional tests will be done when deployed.
Related issues
Backwards compatibility
Not impact