Split etherbase: geth validators flags for e2e tests#6471
Merged
gastonponti merged 8 commits intomasterfrom Jan 18, 2021
Merged
Split etherbase: geth validators flags for e2e tests#6471gastonponti merged 8 commits intomasterfrom
gastonponti merged 8 commits intomasterfrom
Conversation
hbandura
approved these changes
Jan 18, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
### Description Developers could previously avoid rerunning most of the setup for e2e tests by commenting out the `hooks.before()` call. #6471 broke this by adding a new value on geth instances that was set only at `hooks.before` time, but not at `hooks.restart` time. With this PR, the necessary values are set in `hooks.restart`, allowing for e2e test reruns without having to wait for migrations and other initialization steps after having run them once. ### Tested Before, after running the governance e2e tests once, commenting out the `hooks.before()` call, and running the e2e tests again, the tests would fail with "Error: miner.validator address from the instance is required". With these changes, e2e tests run as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add required flags to run a validator, that are needed since the split etherbase change in the blockchain
Backwards compatibility
No. Works only for the instances of geth that already have the etherbase split (since the donut fork)