Skip to content

Add explicit gas to exchange transactions to prevent errors #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
celo-ci-bot-user merged 6 commits into from
Jan 28, 2020
Merged

Add explicit gas to exchange transactions to prevent errors #2552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eac3c81
add explicit gas to exchange transactions to prevent errors
Jan 27, 2020
4fd1760
Merge branch 'master' into victor/exchange-gas
Jan 28, 2020
ce85381
Merge refs/heads/master into victor/exchange-gas
Jan 28, 2020
47afafe
Merge refs/heads/master into victor/exchange-gas
Jan 28, 2020
ea4646b
Merge refs/heads/master into victor/exchange-gas
Jan 28, 2020
260c1ae
Merge refs/heads/master into victor/exchange-gas
Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cli/src/commands/exchange/dollars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export default class ExchangeDollars extends BaseCommand {
await displaySendTx('approve', stableToken.approve(exchange.address, sellAmount.toFixed()))

const exchangeTx = exchange.exchange(sellAmount.toFixed(), minBuyAmount!.toFixed(), false)
await displaySendTx('exchange', exchangeTx)
// Set explciit gas based on github.com/celo-org/celo-monorepo/issues/2541
Copy link
Copy Markdown
Contributor

@mrsmkl mrsmkl Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling.

await displaySendTx('exchange', exchangeTx, { gas: 300000 })
}
}
3 changes: 2 additions & 1 deletion packages/cli/src/commands/exchange/gold.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export default class ExchangeGold extends BaseCommand {
await displaySendTx('approve', goldToken.approve(exchange.address, sellAmount.toFixed()))

const exchangeTx = exchange.exchange(sellAmount.toFixed(), minBuyAmount!.toFixed(), true)
await displaySendTx('exchange', exchangeTx)
// Set explciit gas based on github.com/celo-org/celo-monorepo/issues/2541
await displaySendTx('exchange', exchangeTx, { gas: 300000 })
}
}