Skip to content

Force same bignumber version to fix cloudbuild#2256

Merged
cmcewen merged 1 commit intomasterfrom
cmcewen/fix-cloudbuild
Dec 13, 2019
Merged

Force same bignumber version to fix cloudbuild#2256
cmcewen merged 1 commit intomasterfrom
cmcewen/fix-cloudbuild

Conversation

@cmcewen
Copy link
Copy Markdown
Contributor

@cmcewen cmcewen commented Dec 13, 2019

Description

getting a bunch of

Type 'import("/celo-monorepo/packages/utils/node_modules/bignumber.js/bignumber").BigNumber' is not assignable to type 'import("/celo-monorepo/node_modules/bignumber.js/bignumber").BigNumber'.
test/stability/stabletoken.ts(397,62): error TS2345: Argument of type 'BigNumber' is not assignable to parameter of type 'Value'.
Type 'import("/celo-monorepo/packages/utils/node_modules/bignumber.js/bignumber").BigNumber' is not assignable to type 'import("/celo-monorepo/node_modules/bignumber.js/bignumber").BigNumber'.
test/stability/stabletoken.ts(385,50): error TS2345: Argument of type 'BigNumber' is not assignable to parameter of type 'Value'.```

### Tested

Did docker build locally

Copy link
Copy Markdown
Contributor

@annakaz annakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 can merge with #2554 and #2255 and build is fixed

@cmcewen cmcewen merged commit aa57fb3 into master Dec 13, 2019
aaronmgdr added a commit that referenced this pull request Dec 16, 2019
* master: (40 commits)
  Add utils as a dep (#2252)
  [Wallet] Create run_app.sh script to facilitate app development (#2186)
  [Wallet] Fix persisted data loss on iOS (#2249)
  adds Testing TSX /react on the web (#2229)
  Update running-a-validator.md (#2259)
  Add ts-ignore (#2254)
  Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255)
  Force same bignumber version (#2256)
  Fix missing Text on website (#2237)
  Revert "Upgrade TS version (#2196)" (#2251)
  [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232)
  Fix using requester instead of requestee at Outgoing notifications (#2240)
  Use correct phone placeholder depending on the country on joining Celo view (#2061)
  Update Attestation Bot Docker Image (#2231)
  Baklava phase 1.1 .env file (#2226)
  [Docs] Fix typo (#2225)
  Upgrade Dependencies and get react hooks working (#2203)
  Update attestation service docker images (#2202)
  Updates TME docker images (#2200)
  Remove walletkit from celotool transactions commands (#2206)
  ...

# Conflicts:
#	packages/web/package.json
aaronmgdr added a commit that referenced this pull request Dec 16, 2019
* master:
  Add utils as a dep (#2252)
  [Wallet] Create run_app.sh script to facilitate app development (#2186)
  [Wallet] Fix persisted data loss on iOS (#2249)
  adds Testing TSX /react on the web (#2229)
  Update running-a-validator.md (#2259)
  Add ts-ignore (#2254)
  Revert "Revert "Upgrade TS version (#2196)" (#2251)" (#2255)
  Force same bignumber version (#2256)
  Fix missing Text on website (#2237)
  Revert "Upgrade TS version (#2196)" (#2251)
  [Wallet] Refer to Celo Lite as "Data Saver" mode (#2232)
  Fix using requester instead of requestee at Outgoing notifications (#2240)
  Use correct phone placeholder depending on the country on joining Celo view (#2061)
  Update Attestation Bot Docker Image (#2231)
  Baklava phase 1.1 .env file (#2226)
  [Docs] Fix typo (#2225)
  Upgrade Dependencies and get react hooks working (#2203)
  Update attestation service docker images (#2202)
  Updates TME docker images (#2200)
  Remove walletkit from celotool transactions commands (#2206)
@cmcewen cmcewen deleted the cmcewen/fix-cloudbuild branch December 30, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants