Merged
Conversation
nategraf
reviewed
Mar 27, 2020
nategraf
approved these changes
Mar 28, 2020
oneeman
pushed a commit
that referenced
this pull request
Nov 6, 2020
The original geth implementation of EIP-2200 assumed EIP-1884 was also enabled. It didn't cause problems since both were part of the Istanbul hard fork. But a later commit to geth made EIP-2200's implementation correct apart from EIP-1884. This commit comments out the change to SLOAD's gas cost, which is needed for backwards compatibility, since Celo didn't adopt the corresponding change in EIP-1884 (also commented out in the code), see PR #939.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes EIP 1884 gas changes from the Istanbul hard fork.
Tested
Other changes
Related issues
Backwards compatibility