Allow use of "finalized" tag in rpc requests #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows the use of the "finalized" tag to retrieve blocks or headers via the RPC. Using the "finalized" tag is equivalent to using the "latest" tag because all blocks are final in celo. This is to supprt integration with chainlink since their system depends on retrieving finalized blocks.
|
Coverage from tests in coverage: 50.6% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.7% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.5% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
carterqw2
reviewed
Apr 12, 2024
carterqw2
reviewed
Apr 12, 2024
carterqw2
approved these changes
Apr 12, 2024
ezdac
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Allow use of finalized tag in rpc requests This PR allows the use of the "finalized" tag to retrieve blocks or headers via the RPC. Using the "finalized" tag is equivalent to using the "latest" tag because all blocks are final in celo. This is to supprt integration with chainlink since their system depends on retrieving finalized blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the use of the "finalized" tag to retrieve blocks or
headers via the RPC. Using the "finalized" tag is equivalent to using
the "latest" tag because all blocks are final in celo.
This is to supprt integration with chainlink since their system depends
on retrieving finalized blocks.
Tested
There is a new e2e test that checks the "finalized" tag retrieves the same header as the "latest" tag.