[CIP-50] optional replay protection#1748
Merged
gastonponti merged 5 commits intomasterfrom Dec 7, 2021
Merged
Conversation
Contributor
|
Coverage from tests in coverage: 44.6% of statements across all listed packagescoverage: 54.1% of statements in consensus/istanbul coverage: 44.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 43.3% of statements in consensus/istanbul/backend/internal/db coverage: 24.1% of statements in consensus/istanbul/backend/internal/enodes coverage: 22.4% of statements in consensus/istanbul/backend/internal/replica coverage: 64.2% of statements in consensus/istanbul/core coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 75.3% of statements in consensus/istanbul/uptime coverage: 100.0% of statements in consensus/istanbul/uptime/store coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 09775b3d7b |
gastonponti
force-pushed
the
gastonponti/cip50-optional-replay-protection
branch
from
32ddca7 to
192e3c2
Compare
trianglesphere
approved these changes
Dec 3, 2021
Contributor
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
Blockchain side LGTM. Will need to update CIP-35 e2e test.
Contributor
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
Update around espresso name in tests
trianglesphere
requested review from
a team,
hbandura and
nategraf
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1695
Description
Implementation of the CIP 50, that makes the replay protection optional
Related issues
Backwards compatibility
No. Part of the Expresso hard fork