Cherry-pick: node: relax websocket connection header check (#21646)#1698
Merged
mergify[bot] merged 1 commit intomasterfrom Sep 22, 2021
Merged
Cherry-pick: node: relax websocket connection header check (#21646)#1698mergify[bot] merged 1 commit intomasterfrom
mergify[bot] merged 1 commit intomasterfrom
Conversation
This makes it accept the "upgrade,keep-alive" header value, which apparently is a thing.
Contributor
|
Coverage from tests in |
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
- Coverage 56.09% 56.08% -0.01%
==========================================
Files 606 606
Lines 80269 80269
==========================================
- Hits 45030 45022 -8
- Misses 31703 31717 +14
+ Partials 3536 3530 -6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking from go-ethereum this PR.
The fix from the PR is needed for Kong and the GCP LB to be able to redirect the websocket properly.
Tested
Tested in baklava forno env with and without Kong as proxy:
Related issues
Backwards compatibility
This celo-monorepo PR needs to be merged/used to deploy new celo-blockchain versions to Forno due to this issue (this endpoint change is already on master).