Adds revert reason on eth_call and simulatedBackend#1410
Closed
Adds revert reason on eth_call and simulatedBackend#1410
Conversation
gastonponti
approved these changes
Mar 2, 2021
Contributor
gastonponti
left a comment
gastonponti
left a comment
There was a problem hiding this comment.
LGTM
Some nit and a question
Co-authored-by: Gaston Ponti <pontigaston@gmail.com>
Contributor
|
Looking at how web3 handles this (web3/web3.js@2948927#diff-9050e060908a6957eb4e25bb2f4b8930f5097e55e846e0e8194ff5fa3a3440a4R621-R630), I think we should cherry-pick the upstream PR for this (ethereum/go-ethereum#21083). Because web3 expects the revert reason to either be in |
Contributor
|
Will instead cherry-pick the upstream PR, to maintain compatibility with web3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds smart contract revert reason to the error message when a call to a smart contract fails.
For the case:
eth_callRPCSimulatedBackend.CallContract()Tested
Manual testing