Skip to content

Check if the transactor's balance covers the Tx #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gastonponti wants to merge 1 commit into from
Closed

Check if the transactor's balance covers the Tx #1275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/ethapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,6 @@ func DoCall(ctx context.Context, b Backend, args CallArgs, blockNrOrHash rpc.Blo
// which will always be in Gold. This allows the default price to be set for the proper currency.
// TODO(asa): Remove this once this is handled in the Provider.
if gasPrice.Sign() == 0 || gasPrice.Cmp(big.NewInt(0)) == 0 {
// TODO(mcortesi): change SuggestGastPriceInCurrent so it doesn't return an error
gasPrice, err = b.SuggestPriceInCurrency(ctx, args.FeeCurrency, header, state)
if err != nil {
log.Error("Error suggesting gas price", "block", blockNrOrHash, "err", err)
Expand Down Expand Up @@ -869,6 +868,10 @@ func DoCall(ctx context.Context, b Backend, args CallArgs, blockNrOrHash rpc.Blo
if estimate {
res, gas, failed, err = core.ApplyEstimatorMessage(evm, msg, gp)
} else {
transaction := types.NewTransaction(msg.Nonce(), *msg.To(), msg.Value(), msg.Gas(), msg.GasPrice(), msg.FeeCurrency(), msg.GatewayFeeRecipient(), msg.GatewayFee(), msg.Data())
if err := core.ValidateTransactorBalanceCoversTx(transaction, addr, state); err != nil {
return nil, 0, false, err
}
res, gas, failed, err = core.ApplyMessage(evm, msg, gp)
}

Expand Down