refactor!: type paramed Header interface #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs and
gupadhyaya
as code owners
Wondertan
commented
Aug 21, 2023
Wondertan
changed the title
Wondertan
force-pushed
the
type-paramed-header
branch
from
9497efb
to
e3862da
Compare
Wondertan
force-pushed
the
type-paramed-header
branch
from
175f983
to
b171776
Compare
vgonkivs
approved these changes
Aug 25, 2023
renaynay
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to improve type safety. Before, go-header users had to do type checks as https://github.com/celestiaorg/celestia-node/blob/main/header/verify.go#L12-L17. This PR parametrized the Header interface so that type safety is ensured during compilation rather than runtime