-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: celestia-app docker document #1364
feat: celestia-app docker document #1364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be formatted properly and linted
formatted the file.
formatted the file
what OS have you tested this on @ogunleye0720 ? |
Linux |
|
Okay, @jcstein I'm new to opensource. Thanks for pointing this out, I'll work on it. |
no worries! thank you. note for myself too :) i'll also be testing this on mac for final review |
WalkthroughThe update significantly enhances the documentation for Celestia, specifically for running Celestia App and Celestia Node using Docker. It transforms the previous instructions into a comprehensive guide with structured sections, detailed prerequisites, quick-start instructions, and troubleshooting tips, all aimed at simplifying the setup and management of Celestia components in Docker environments. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/celestia-app-docker-image.md (1 hunks)
Additional comments: 3
nodes/celestia-app-docker-image.md (3)
- 1-4: The metadata section correctly specifies the sidebar label and description for the documentation page. This ensures proper categorization and description in the documentation site's navigation structure.
- 6-20: The introduction and overview sections provide a clear and concise explanation of the purpose of the documentation and the functionality of the
celestia-app txsim
binary. This sets a solid foundation for the reader's understanding.- 67-67: The closing statement effectively congratulates the user on successfully setting up the Celestia app in Docker, which is a nice touch for user encouragement and satisfaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/celestia-app-docker-image.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- nodes/celestia-app-docker-image.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/celestia-app-docker-image.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- nodes/celestia-app-docker-image.md
Don't we need to remove |
doc: removed nodes/celestia-app-docker-image.d
Done @jcstein I have created a pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/docker-images.md (5 hunks)
Additional Context Used
Additional comments not posted (9)
nodes/docker-images.md (9)
2-3
: The metadata section is clear and concise, providing a good summary of the document's purpose.
55-62
: The Docker installation instructions are straightforward and include links for different operating systems, which is helpful. However, the list formatting for Docker installation options could be improved for better readability.Consider adding a newline before the "Ensure you have a basic understanding of Docker to proceed." for better separation and readability.
66-73
: The overview of Celestia-Apptxsim
provides a good introduction to the tool and its purpose. It's clear and concise, effectively setting the stage for the detailed instructions that follow.
83-120
: The Celestia-App Quick-Start guide is well-structured and provides a clear, step-by-step process for setting up Celestia-App using Docker. Each step is explained in detail, making it easy for users to follow along.
122-146
: The Flag Breakdown section is a valuable addition, offering users a clear understanding of the options available when running thetxsim
Docker image. It's well-organized and informative.
150-152
: The introduction to the Celestia-Node setup guide is concise and sets clear expectations for the reader. It's a good transition into the more detailed setup instructions that follow.
262-272
: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [231-267]
The section on light node setup with persistent storage is particularly important for users who want to maintain their node data across container restarts. The instructions are clear, but consider adding a note about the importance of backing up critical data, especially for production environments.
Consider adding a note on the importance of data backup for critical node data, especially in production environments.
345-359
: The inclusion of video walkthroughs is an excellent way to provide visual learners with an alternative way to understand the setup process. However, ensure that the videos are up-to-date with the written instructions to avoid confusion.
371-373
: The troubleshooting section addresses a common issue for Windows users regarding file permissions. This is a valuable inclusion for ensuring a smooth setup process across different operating systems. However, consider adding a brief explanation or link about WSL for users who might not be familiar with it.Consider adding a brief explanation or link about Windows Subsystem for Linux (WSL) for users who might not be familiar with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/docker-images.md (5 hunks)
Additional Context Used
Additional comments not posted (4)
nodes/docker-images.md (4)
1-3
: The metadata is clear and accurately describes the content of the document. However, ensure that thesidebar_label
matches the expected naming conventions used throughout the project for consistency.
64-147
: The Celestia-App Setup with Docker section is comprehensive and provides detailed instructions for setting up Celestia-App using Docker. Ensure that all code snippets are tested and that the links to further resources are up-to-date.
31-155
: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [148-223]
The Celestia-Node Setup with Docker section provides clear instructions for setting up Celestia-Node using Docker. Ensure that the environment variables and command-line options mentioned are accurate and up-to-date.
345-359
: The Video Walkthrough section is a valuable addition, providing visual guidance for users. Ensure that the videos are kept up-to-date with the latest version of the software and documentation.
## Introduction | ||
|
||
Using Docker is the easiest way to run celestia-node for most | ||
users. Docker is a containerization platform that allows you to run celestia-node | ||
in an isolated environment. | ||
This page provides instructions on how to set up both the Celestia-App and | ||
the Celestia-Node using Docker. | ||
see [celestia-node page](./celestia-node.md) for additional instructions | ||
to run celestia-node using Docker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction succinctly explains the purpose of the document. However, the sentence starting with "see" should start with a capital letter for consistency and professionalism.
-see [celestia-node page](./celestia-node.md) for additional instructions
+See [celestia-node page](./celestia-node.md) for additional instructions
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
## Introduction | |
Using Docker is the easiest way to run celestia-node for most | |
users. Docker is a containerization platform that allows you to run celestia-node | |
in an isolated environment. | |
This page provides instructions on how to set up both the Celestia-App and | |
the Celestia-Node using Docker. | |
see [celestia-node page](./celestia-node.md) for additional instructions | |
to run celestia-node using Docker. | |
## Introduction | |
This page provides instructions on how to set up both the Celestia-App and | |
the Celestia-Node using Docker. | |
See [celestia-node page](./celestia-node.md) for additional instructions | |
to run celestia-node using Docker. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
gm @ogunleye0720 do you want to clean this up and get it merged? |
Using Docker is the easiest way to run celestia-node for most | ||
users. Docker is a containerization platform that allows you to run celestia-node | ||
in an isolated environment. | ||
This page provides instructions on how to set up both the Celestia-App and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- use celestia-app and celestia-node throughout this document
Using Docker is the easiest way to run celestia-node for most | ||
users. Docker is a containerization platform that allows you to run celestia-node | ||
in an isolated environment. | ||
This page provides instructions on how to set up both the Celestia-App and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page provides instructions on how to set up both the Celestia-App and | |
This page provides instructions on how to set up both celestia-app and |
users. Docker is a containerization platform that allows you to run celestia-node | ||
in an isolated environment. | ||
This page provides instructions on how to set up both the Celestia-App and | ||
the Celestia-Node using Docker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Celestia-Node using Docker. | |
celestia-node using Docker. |
in an isolated environment. | ||
This page provides instructions on how to set up both the Celestia-App and | ||
the Celestia-Node using Docker. | ||
see [celestia-node page](./celestia-node.md) for additional instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it is on this page, is this AI-generated??
for running applications in isolated environments on any | ||
operating system. | ||
|
||
This means that you can run Celestia-app & celestia-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that you can run Celestia-app & celestia-node | |
This means that you can run celestia-app & celestia-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (13)
nodes/docker-images.md (13)
3-3
: Enhance the description for better clarity.The description could be more descriptive to better reflect the content of the document.
-description: Comprehensive guide for setting up celestia-app and celestia-node using Docker. +description: Comprehensive guide for setting up and running Celestia-App and Celestia-Node using Docker.
6-6
: Capitalize proper nouns in the title.For consistency with the rest of the document and to match proper nouns, consider capitalizing "App" and "Node".
-# Celestia-app and celestia-node setup with Docker 🐳 +# Celestia-App and Celestia-Node setup with Docker 🐳
10-23
: Ensure consistency in capitalization for ToC entries.The ToC entries should consistently use title case for better readability.
-1. [Introduction](#introduction) -2. [Docker Installation](#docker-installation) -3. [Celestia-app Setup With Docker](#celestia-app-setup-with-docker) - - [Overview of celestia-app txsim](#overview-of-celestia-app-txsim) - - [Prerequisites to run celestia-app on Docker](#prerequisites-to-run-celestia-app-on-docker) - - [Celestia-app Quick-Start](#celestia-app-quick-start) - - [Flag Breakdown](#flag-breakdown) -4. [Celestia-node Setup With Docker](#celestia-node-setup-with-docker) - - [Celestia-node Quick start](#celestia-node-quick-start) - - [Light node setup with persistent storage](#light-node-setup-with-persistent-storage) - - [Initialize the node store and key](#initialize-the-node-store-and-key) - - [Start the node](#start-the-node) -5. [Video walkthrough](#video-walkthrough) -6. [Troubleshooting](#troubleshooting) +1. [Introduction](#introduction) +2. [Docker Installation](#docker-installation) +3. [Celestia-App Setup With Docker](#celestia-app-setup-with-docker) + - [Overview of Celestia-App txsim](#overview-of-celestia-app-txsim) + - [Prerequisites to Run Celestia-App on Docker](#prerequisites-to-run-celestia-app-on-docker) + - [Celestia-App Quick-Start](#celestia-app-quick-start) + - [Flag Breakdown](#flag-breakdown) +4. [Celestia-Node Setup With Docker](#celestia-node-setup-with-docker) + - [Celestia-Node Quick Start](#celestia-node-quick-start) + - [Light Node Setup with Persistent Storage](#light-node-setup-with-persistent-storage) + - [Initialize the Node Store and Key](#initialize-the-node-store-and-key) + - [Start the Node](#start-the-node) +5. [Video Walkthrough](#video-walkthrough) +6. [Troubleshooting](#troubleshooting)
36-39
: Ensure the introduction starts with a capital letter.The sentence starting with "see" should start with a capital letter for consistency and professionalism.
-see [celestia-node page](./celestia-node.md) for additional instructions +See [celestia-node page](./celestia-node.md) for additional instructions
45-47
: Capitalize proper nouns in the introduction.For consistency, capitalize "App" and "Node".
-This means that you can run Celestia-app & celestia-node +This means that you can run Celestia-App & Celestia-Node
58-62
: Improve the formatting for Docker installation options.The formatting for the list of Docker installation options can be improved for better readability.
-[Docker Desktop for Mac or Windows](https://docs.docker.com/get-docker) or - - [Docker Engine for Linux](https://docs.docker.com/engine/install/) - - basic understanding of Docker +- [Docker Desktop for Mac or Windows](https://docs.docker.com/get-docker) +- [Docker Engine for Linux](https://docs.docker.com/engine/install/) + +Ensure you have a basic understanding of Docker to proceed.
101-103
: Clarify file permission requirements.The sentence "A simple read access is all that is required" can be clarified for better understanding.
-A simple read access is all that is required for the +Read access is all that is required for the
120-120
: Ensure consistency in capitalization and punctuation.The sentence should maintain consistency in capitalization and punctuation for professionalism.
-Congratulations! You have successfully set up Celestia-App in Docker 😎 +Congratulations! You have successfully set up Celestia-App in Docker. 😎
223-223
: Ensure consistency in capitalization and punctuation.The sentence should maintain consistency in capitalization and punctuation for professionalism.
-Congratulations! You now have a Celestia-Node running 😎 +Congratulations! You now have a Celestia-Node running. 😎
341-341
: Ensure consistency in capitalization and punctuation.The sentence should maintain consistency in capitalization and punctuation for professionalism.
-Congratulations! You now have a node running with persistent storage 😎. +Congratulations! You now have a node running with persistent storage. 😎
345-359
: Ensure consistency in capitalization for section titles.The section title should consistently use title case for better readability.
-### 2.5 minute version +### 2.5 Minute Version
36-39
: Clarify the introduction sentence.The introduction sentence is incomplete and lacks clarity. It should clearly state the purpose of the document.
-This page provides instructions on how to both the Celestia-app and -the Celestia-node using Docker. -see [celestia-node page](./celestia-node.md). for instructions to run -celestia-node using Docker. +This page provides comprehensive instructions on how to set up and run both Celestia-App and Celestia-Node using Docker. For additional details on running Celestia-Node, see the [Celestia-Node page](./celestia-node.md).
2-2
: Ensure consistency in sidebar label.The sidebar label should use title case for consistency.
-sidebar_label: Docker images +sidebar_label: Docker Images
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- nodes/docker-images.md (5 hunks)
Additional comments not posted (1)
nodes/docker-images.md (1)
75-81
: Fix typo in the prerequisites section.There's a typo in "Prequisites". It should be "Prerequisites".
-### Prequisites to run Celestia-App on Docker +### Prerequisites to run Celestia-App on DockerLikely invalid or redundant comment.
For security purposes, Celestia expects to interact with your node's keys in a read-only manner. This is enforced using linux style permissions | ||
on the filesystem. Windows NTFS does not support these types of permissions. | ||
As a result the recommended path for Windows users to mount a persisted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expand the Troubleshooting section with additional tips.
Consider expanding this section with additional common issues and their solutions to further assist users.
Would you like me to suggest additional troubleshooting tips to include here?
Tools
LanguageTool
[typographical] ~373-~373: Consider adding a comma after this introductory phrase.
Context: ...upport these types of permissions. As a result the recommended path for Windows users ...(AS_A_NN_COMMA)
|
||
- Ensure you have a basic understanding of Docker to proceed. | ||
|
||
## Celestia-App Setup with Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use celestia-app in this heading
|
||
This guide provides instructions on how to use the Celestia `txsim` Docker image. | ||
|
||
### Overview of Celestia-App `txsim` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this? ive never heard of it? is this ai-generated?
The Celestia-App `txsim` binary is a tool that can be | ||
used to simulate transactions on the Celestia network. | ||
It can be used to test the performance of the Celestia network. | ||
The txsim Docker image runs the `txsim` binary with multiple configurable options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
????????
|
||
## Quick start | ||
3. Using a suitable text editor of your choice, open the | ||
.celestia-app file and paste the keyring of the prefunded account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
????
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai-generated. closing this PR
Overview
Checklist
Summary by CodeRabbit
docker-images.md
with a comprehensive guide for setting up Celestia-App and Celestia-Node using Docker, featuring improved navigation, detailed prerequisites, step-by-step instructions, and additional visual resources for user assistance.