Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run yarn lint #1332

Merged
merged 1 commit into from
Dec 15, 2023
Merged

chore: run yarn lint #1332

merged 1 commit into from
Dec 15, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Dec 14, 2023

While working on a different PR, the commit pre-hook failed because yarn lint resulted in a diff. Since these changes are unrelated to my PR, I included them here.

Note: I wonder why CI lint didn't catch these? Do we want an issue to investigate the discrepancy between local lint and CI lint?

@rootulp rootulp requested a review from jcstein December 14, 2023 20:05
@rootulp rootulp self-assigned this Dec 14, 2023
@jcstein
Copy link
Member

jcstein commented Dec 14, 2023

I had this happen to me and added the linting in a PR I have open (not best practice), so thanks for opening this. Just reverted the commit on that PR.

Note: I wonder why CI lint didn't catch these? Do we want an issue to investigate the discrepancy between local lint and CI lint?

It doesn't look like there is a CI lint on the most recent PRs...so looking into that now.

Regardless, I think that we do need to look into the flow of the linting with the pre-commit hook, and whether it should also exist the same way as CI, as I don't see it running on this PR? As for now, it only is used if developer downloads dependencies, otherwise husky won't run the pre-commit EDIT: i think that I took off the CI check when I added husky. So it is time to add it back i think.

@jcstein
Copy link
Member

jcstein commented Dec 14, 2023

NOTE: the changes to blobstream-orchestrator/relayer should be made on the source of orchestrator-relayer repo, as well, as it is the "source" for these docs https://github.com/celestiaorg/docs/pull/1332/files#diff-71a7959e9b9aa32e7c4bf07cd396250ce69e30364ffe584c8188205ba03c01f4

UPDATE: done here in an open PR to orchestrator-relayer celestiaorg/orchestrator-relayer#661

@jcstein jcstein merged commit 93e6c0b into celestiaorg:main Dec 15, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants