add method to export runTx for PreprocessTxs #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
force-pushed
the
evan/export-runTx
branch
from
438033c to
8943f14
Compare
14 tasks
Member
|
Let's figure this out first: celestiaorg/celestia-app#21 (comment) |
Member
Author
|
After talking with @liamsi, this PR is no longer needed, as we are not running the transaction during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply adds a method to
Baseappto export runTx. Access torunTxoutside ofBaseappis needed before the newPreprocessTxsABCI method can be merged.closes: #XXXX