cmd: main function, full and light commands with subcommands #97

Wondertan · 2021-09-29T21:38:57Z

Context

Finally, the main function with cobra commands to run our work. The PR also introduces a pattern for reusable commands in cmd package.

Other Changes

Improves logging
Fixes a bug where lock for repo is applied on nonexisting directory
node.ParseType to parse NodeType from a string
And others described in commits...

TODO

Make ASCI art visible on every help(optional)
Make start command

Refs

Closes #17

liamsi

Looks good. Please make sure the code is properly formatted as the linter suggested tho.

node/init.go

node/type.go

Wondertan · 2021-09-30T16:54:23Z

@liamsi, @renaynay, start command works now for Full and Light node. Tested them manually along with init, works like a charm.

cmd/start.go

renaynay

comments but otherwise lgtm

cmd/celestia/main.go

cmd/celestia/full.go

cmd/celestia/light.go

cmd/start.go

node/init.go

node/node.go

…ing 'cobra'

…est for the case

…ption

core/config.go

liamsi

Thanks a lot @Wondertan 👏🏼

renaynay

yay

Wondertan · 2021-10-18T13:49:33Z

node/init.go

@@ -55,9 +54,9 @@ func InitWith(path string, tp Type, cfg *Config) error {
 		if err != nil {
 			return err
 		}
-		log.Info("Saving config")
+		log.Infow("Saving config", "path", cfgPath)


@renaynay, What's the point of this log if it duplicates Initializing %s Node Repository over '%s' above? I mean it logs the path to the repo and cfg is constantly repo_path+config.toml, so not sure if there is a point to add this path here, but it does not hurt anyway.

Wondertan self-assigned this Sep 29, 2021

Wondertan requested review from liamsi, mattdf and renaynay as code owners September 29, 2021 21:38

liamsi reviewed Sep 30, 2021

View reviewed changes

node/init.go Outdated Show resolved Hide resolved

node/type.go Show resolved Hide resolved

Wondertan force-pushed the hlib/main branch from b229ea6 to 232c55a Compare September 30, 2021 16:51

Wondertan requested a review from liamsi September 30, 2021 16:54

mattdf reviewed Oct 1, 2021

View reviewed changes

cmd/start.go Show resolved Hide resolved

mattdf reviewed Oct 1, 2021

View reviewed changes

cmd/start.go Show resolved Hide resolved

renaynay reviewed Oct 4, 2021

View reviewed changes

Wondertan mentioned this pull request Oct 9, 2021

node: Node knows of its own Type #123

Closed

This was referenced Oct 11, 2021

node/p2p: Libp2p logs too verbose, reduce to important logs only #127

Closed

cmd: Investigate completion option in cli #128

Closed

cmd: Add better/more thorough descriptions to CLI commands/flags #129

Closed

Wondertan and others added 15 commits October 11, 2021 10:41

feat(node): add Node Type parsing from string

5ec7b71

feat(node): new InitWith to allow custom configs

b686db1

fix(node): ensure root is created before locking and improve logging

90397e8

feat(cmd): start implementing CLI with Init command ing cmd packge us…

dd08680

…ing 'cobra'

feat(cmd/celestia): main function with full and light commands

308a05c

cmd: multiple improvements and ASCI art

af554fc

cmd: write error to stdout

85be259

fix(core): make core run kvapp by default

476ea14

fix(node): fs repo should load and save config over config path and t…

da77456

…est for the case

fix(node): fix bug where Full Node was a light Node

9173724

fix(node): track Start/Stop cancelation timeout with global timeout o…

e781454

…ption

feat(cmd): start command

6661883

feat(cmd/celestia): add start command

769b747

chore(fmt): make linter happy throughout ther project

f1c24ad

renes fixes

8082ae2

renaynay force-pushed the hlib/main branch from 4601422 to 8082ae2 Compare October 11, 2021 09:43

renaynay mentioned this pull request Oct 11, 2021

node/rpc: Implement simple RPC server #124

Merged

renaynay requested review from mattdf and renaynay October 11, 2021 11:09

liamsi reviewed Oct 11, 2021

View reviewed changes

core/config.go Show resolved Hide resolved

liamsi approved these changes Oct 11, 2021

View reviewed changes

liamsi mentioned this pull request Oct 11, 2021

Further clarify relation of abci-app in the embedded case #130

Closed

renaynay approved these changes Oct 11, 2021

View reviewed changes

renaynay merged commit a494536 into main Oct 11, 2021

renaynay deleted the hlib/main branch October 11, 2021 11:38

renaynay restored the hlib/main branch October 11, 2021 11:38

renaynay mentioned this pull request Oct 11, 2021

node: Make Node aware of its own Type #122

Closed

liamsi deleted the hlib/main branch October 15, 2021 13:31

Wondertan commented Oct 18, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd: main function, full and light commands with subcommands #97

cmd: main function, full and light commands with subcommands #97

Wondertan commented Sep 29, 2021 •

edited

Loading

liamsi left a comment

Wondertan commented Sep 30, 2021 •

edited

Loading

renaynay left a comment

liamsi left a comment

renaynay left a comment

Wondertan Oct 18, 2021

cmd: main function, full and light commands with subcommands #97

cmd: main function, full and light commands with subcommands #97

Conversation

Wondertan commented Sep 29, 2021 • edited Loading

Context

Other Changes

TODO

Refs

liamsi left a comment

Choose a reason for hiding this comment

Wondertan commented Sep 30, 2021 • edited Loading

renaynay left a comment

Choose a reason for hiding this comment

liamsi left a comment

Choose a reason for hiding this comment

renaynay left a comment

Choose a reason for hiding this comment

Wondertan Oct 18, 2021

Choose a reason for hiding this comment

Wondertan commented Sep 29, 2021 •

edited

Loading

Wondertan commented Sep 30, 2021 •

edited

Loading