node: use Repository on the Node and slightly improve testing utilites #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l them in one place and (2)make them importable. Unfortunately those testing functions will be part of the build
…ests; remove old in-memory Datastore and put ConfigLoader in the Node instead of just Config
This was referenced Sep 28, 2021
Merged
renaynay
reviewed
Sep 29, 2021
There was a problem hiding this comment.
I don't really get why we need the LoadConfig stuff - makes things more complicated for no reason. Let's just load the config during initialisation and store the pointer to the config on the Node please. I really want the Node init logic to be as clear and possible.
Co-authored-by: rene <[email protected]>
renaynay
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the last TODO of #86.
Changes
nodeandcorepackages into testing.go