share/discovery: make constants configurable

[vgonkivs]

Resolves #929

[renaynay]

nits otherwise lgtm

[vgonkivs]

Test failed because of #931

[Wondertan]

LGTM, but ideally, we would avoid making the discovery constructor public and pass configs with share pkg-specific options. That is, options on the node would trigger options on the share, but this has very low prio

[vgonkivs]

LGTM, but ideally, we would avoid making the discovery constructor public and pass configs with share pkg-specific options. That is, options on the node would trigger options on the share, but this has very low prio

Would you mind if I create an issue for that? @Wondertan

[Wondertan]

Let's do

[codecov-commenter]

Codecov Report

Merging #930 (ef406a9) into main (8eee5c9) will increase coverage by 0.07%.
The diff coverage is 73.49%.

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   58.70%   58.78%   +0.07%     
==========================================
  Files         128      128              
  Lines        7624     7681      +57     
==========================================
+ Hits         4476     4515      +39     
- Misses       2678     2696      +18     
  Partials      470      470              

Impacted Files	Coverage Δ
node/config_opts.go	28.57% <0.00%> (-11.43%)	⬇️
service/share/discovery.go	34.72% <50.00%> (+0.87%)	⬆️
node/components.go	90.69% <100.00%> (ø)
node/services/config.go	51.51% <100.00%> (+4.84%)	⬆️
node/services/service.go	81.87% <100.00%> (+4.19%)	⬆️
service/share/full_availability.go	88.23% <100.00%> (ø)
service/share/light_availability.go	84.48% <100.00%> (ø)
service/share/testing.go	82.75% <100.00%> (+0.24%)	⬆️
cmd/flags_core.go	42.37% <0.00%> (-0.74%)	⬇️
header/core/listener.go	58.49% <0.00%> (+5.66%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.