fix(share): protect datastore autobatch in CacheAvailability with a lock #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
added
area:shares
vgonkivs
approved these changes
Jun 29, 2022
Wondertan
commented
Jun 29, 2022
renaynay
reviewed
Jun 29, 2022
Wondertan
force-pushed
the
hlib/fix-cache-avail
branch
from
1240a79 to
c37610e
Compare
Wondertan
force-pushed
the
hlib/fix-cache-avail
branch
from
c37610e to
380b6ba
Compare
renaynay
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the review of #786, I was assuming the autobatch datastore has an internal lock, but it turns out to be not the case.
Was found while making #592