Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fraud: implement fraud service #811

Merged

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jun 9, 2022

Implemented fraud service on top of fraud interface.

@vgonkivs vgonkivs added kind:feat Attached to feature PRs area:fraud labels Jun 9, 2022
@vgonkivs vgonkivs self-assigned this Jun 9, 2022
@vgonkivs vgonkivs mentioned this pull request Jun 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #811 (f644123) into main (aee88c2) will increase coverage by 0.55%.
The diff coverage is 43.54%.

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   53.03%   53.58%   +0.55%     
==========================================
  Files         117      122       +5     
  Lines        6760     6957     +197     
==========================================
+ Hits         3585     3728     +143     
- Misses       2810     2844      +34     
- Partials      365      385      +20     
Impacted Files Coverage Δ
fraud/bad_encoding.go 43.75% <0.00%> (+9.30%) ⬆️
fraud/subscription.go 21.42% <21.42%> (ø)
fraud/service.go 48.48% <48.48%> (ø)
fraud/topic.go 60.00% <60.00%> (ø)
service/share/full_availability.go 52.38% <0.00%> (-41.37%) ⬇️
service/share/light_availability.go 76.19% <0.00%> (-7.15%) ⬇️
ipld/retriever.go 83.45% <0.00%> (-4.32%) ⬇️
service/rpc/server.go 79.06% <0.00%> (-0.94%) ⬇️
node/rpc/component.go 100.00% <0.00%> (ø)
service/share/testing.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee88c2...f644123. Read the comment docs.

fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good 🚀

fraud/service.go Show resolved Hide resolved
fraud/topic.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/topic.go Outdated Show resolved Hide resolved
fraud/topic.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Show resolved Hide resolved
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We should add a few simple units here and we are fully read to go

fraud/service.go Show resolved Hide resolved
fraud/service.go Outdated Show resolved Hide resolved
fraud/service.go Show resolved Hide resolved
fraud/service.go Show resolved Hide resolved
fraud/service.go Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the implement_fraud_service_based_on_interface branch from 9de0500 to 7b0ef6d Compare June 13, 2022 14:20
fraud/subscription.go Outdated Show resolved Hide resolved
fraud/service_test.go Show resolved Hide resolved
@vgonkivs
Copy link
Member Author

Снимок экрана 2022-06-13 в 17 46 03

@vgonkivs
Copy link
Member Author

Failed test is a known issue. It will be resolved within #815

@vgonkivs vgonkivs merged commit 7833e04 into celestiaorg:main Jun 13, 2022
@vgonkivs vgonkivs deleted the implement_fraud_service_based_on_interface branch January 9, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fraud kind:feat Attached to feature PRs
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants