Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ipld): simply rely on global rsmt2d.Codec constructor for now to avoid races #722

Merged
merged 1 commit into from
May 17, 2022
Merged

fix(ipld): simply rely on global rsmt2d.Codec constructor for now to avoid races #722

merged 1 commit into from
May 17, 2022

Conversation

Wondertan
Copy link
Member

Closes #719

@Wondertan Wondertan added area:ipld IPLD plugin kind:fix Attached to bug-fixing PRs labels May 17, 2022
@Wondertan Wondertan requested a review from liamsi as a code owner May 17, 2022 10:09
@Wondertan Wondertan self-assigned this May 17, 2022
@Wondertan Wondertan requested a review from renaynay as a code owner May 17, 2022 10:09
renaynay
renaynay approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g

@Wondertan Wondertan merged commit 90ba117 into main May 17, 2022
@Wondertan Wondertan deleted the hlib/codec-race-fix branch May 17, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bidon15 Bidon15 Bidon15 approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

@liamsi liamsi Awaiting requested review from liamsi

Assignees

@Wondertan Wondertan

Labels
area:ipld IPLD plugin kind:fix Attached to bug-fixing PRs
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipld: Retriever shouldn't reuse the same rsmt2d codec for multiple retrievals
4 participants
@Wondertan @Bidon15 @vgonkivs @renaynay