service/header: add network name to protocol ID #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
approved these changes
Mar 6, 2022
There was a problem hiding this comment.
LGTM and thanks for the contribution @toanngosy !
@Wondertan is this the format you were thinking?
We also need to add a changelog entry for this.
|
Thanks @renaynay ! I added the change into |
toanngosy
changed the title
renaynay
approved these changes
Mar 7, 2022
Wondertan
requested changes
Mar 7, 2022
|
@toanngosy, we did some chore changes on the master that cause fails here, pls do rebase |
|
@Wondertan it should work now 😄 |
|
Pls look at the commit history, @toanngosy. There are multiple duplicates from the master. Seems like artifacts from the rebasr. Needs to be fixed |
toanngosy
force-pushed
the
service_header
branch
2 times, most recently
from
b2e2fb0 to
ac38780
Compare
toanngosy
force-pushed
the
service_header
branch
from
ac38780 to
79b49ea
Compare
|
sorry, I fixed it. It is now up to date with the main. @Wondertan |
renaynay
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request would close #493.