Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass trusted peers to config #455

Merged
merged 12 commits into from
Feb 21, 2022
Merged

Pass trusted peers to config #455

merged 12 commits into from
Feb 21, 2022

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Feb 17, 2022 •
edited
Loading

Fixes #364

Chages:

  • multiple trusted peers can be passed on node initialisation;
  • trusted peer will be taken randomly on performRequest;

@vgonkivs vgonkivs marked this pull request as ready for review February 17, 2022 15:09
@Wondertan
Copy link
Member

Wondertan commented Feb 17, 2022 •
edited
Loading

to be consistent, pls further call changelog commits as changelog: add an entry for #PRN

cc @renaynay, it is worth adding to our contribution guidelines.

Wondertan
Wondertan reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

cmd/flags_header.go Show resolved Hide resolved
node/services/config.go Outdated Show resolved Hide resolved
node/services/config.go Outdated Show resolved Hide resolved
service/header/p2p_exchange.go Outdated Show resolved Hide resolved
service/header/p2p_exchange.go Outdated Show resolved Hide resolved
service/header/p2p_exchange_test.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Feb 17, 2022
View reviewed changes
CHANGELOG-PENDING.md Outdated Show resolved Hide resolved
liamsi
liamsi reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hlib's comments are on point. I do not have anything to add :)

@vgonkivs vgonkivs requested review from liamsi and Wondertan February 17, 2022 18:32
liamsi
liamsi previously approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👏🙌👌

renaynay
renaynay reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Some small comments.

node/services/config.go Show resolved Hide resolved
service/header/p2p_exchange.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs requested review from renaynay and liamsi February 18, 2022 09:20
renaynay
renaynay approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@renaynay renaynay added the area:config CLI and config label Feb 18, 2022
@vgonkivs vgonkivs merged commit 60cae73 into celestiaorg:main Feb 21, 2022
@Wondertan Wondertan mentioned this pull request Mar 23, 2022
Merged
@vgonkivs vgonkivs deleted the pass_trusted_peers_to_config branch June 6, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

Assignees
No one assigned
Labels
area:config CLI and config area:p2p
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: Light node can be initialised with multiple trusted peers
4 participants
@vgonkivs @Wondertan @liamsi @renaynay