Conversation
Wondertan
requested review from
cristaloleg,
renaynay,
vgonkivs and
walldiss
as code owners
Member
Author
|
Well, we are blocked on ipfs/boxo#842 now |
Wondertan
force-pushed
the
bump-boxo
branch
2 times, most recently
from
aa9b9c4 to
5c5cd23
Compare
Member
Author
Wondertan
force-pushed
the
bump-boxo
branch
2 times, most recently
from
0039f17 to
f82bf26
Compare
Wondertan
force-pushed
the
bump-boxo
branch
11 times, most recently
from
761f320 to
023b9b2
Compare
Member
Author
|
And ipfs/boxo#872 |
Member
Author
|
This endeavour is another confirmation on why we should move away from BS |
vgonkivs
previously approved these changes
Mar 6, 2025
Member
Author
|
Issue: #4151 |
walldiss
reviewed
Mar 6, 2025
Member
|
Would be great if you can add details on what was the issue and what is the fix to PR description, because right now is not quite clear what and why are the changes |
Member
Author
|
I added a brief explanation on the issue above with link to commit having the biggest impact. I agree it would be better to explain every single change. |
walldiss
previously approved these changes
Mar 6, 2025
renaynay
previously approved these changes
Mar 6, 2025
cristaloleg
previously approved these changes
Mar 7, 2025
Wondertan
dismissed stale reviews from cristaloleg, renaynay, walldiss, and vgonkivs
via
b1d622d
Wondertan
force-pushed
the
bump-boxo
branch
2 times, most recently
from
143b42f to
f5399ae
Compare
Wondertan
commented
Mar 10, 2025
cristaloleg
approved these changes
Mar 11, 2025
renaynay
approved these changes
Mar 11, 2025
walldiss
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As ipfs/boxo#752 is resolved now with all the reported leaks fixed,
we can now unfork boxoWe actually can't. We found another leak induced by high peer churn. The fork now contains a few more ugly hacky changes to minimize the impact of the leak, but doesn't completely solves it. The follow up issue is on its way