service/header: fix ExtendedHeader message duplicates on the network #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
commented
Feb 2, 2022
|
#237 seems like a PR, did you link to the right thing? |
adlerjohn
reviewed
Feb 3, 2022
renaynay
reviewed
Feb 3, 2022
|
Thank you for catching this. No, I linked the wrong thing.
|
Co-authored-by: John Adler <[email protected]>
Co-authored-by: rene <[email protected]>
Wondertan
force-pushed
the
hlib/dedup-headers
branch
from
5d8fff6 to
4a6cf9c
Compare
|
Just tested manually on my node that this works as expected and there are no duplicate header logs anymore! |
…ing validation and document error handling
adlerjohn
previously approved these changes
Feb 12, 2022
|
A quick note that we are now maintaining our own fork of pubsub due to #409 (comment) |
liamsi
reviewed
Feb 14, 2022
liamsi
approved these changes
Feb 14, 2022
Bidon15
pushed a commit
to Bidon15/celestia-node
that referenced
this pull request
Feb 15, 2022
Bidon15
pushed a commit
to Bidon15/celestia-node
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Finally, a fix to solve this longstanding issue.
How
By using a new feature in libp2p/go-libp2p-pubsub#468 we can now implement custom per-topic message id generation where for the 'HeaderSub' we avoid Signatures from being hashed.
TODO
- [ ] An integration test to assert this is exactly trueWe don't have a way to fully simulate this case, as we don't have a test suite to run multiple core validating nodes per test, which we need to rcv multiple headers with different commit set.
Closes #236