Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(docgen): simplify init #3997

Merged
merged 4 commits into from
Dec 23, 2024
Merged

refactor(docgen): simplify init #3997

merged 4 commits into from
Dec 23, 2024

Conversation

cristaloleg
Copy link
Contributor

Adding add(v any) and must that simplifies life.

@cristaloleg cristaloleg added the kind:refactor Attached to refactoring PRs label Dec 11, 2024
@cristaloleg cristaloleg self-assigned this Dec 11, 2024
Wondertan
Wondertan reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failure, otherwise LGTM

@cristaloleg cristaloleg changed the title fix(share): type in assert docgen: simplify init Dec 11, 2024
@cristaloleg cristaloleg changed the title docgen: simplify init refactor(docgen): simplify init Dec 11, 2024
@cristaloleg cristaloleg enabled auto-merge (squash) December 11, 2024 20:09
renaynay
renaynay approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@cristaloleg cristaloleg merged commit 4d3d3c2 into main Dec 23, 2024
21 checks passed
@cristaloleg cristaloleg deleted the refactor/simpler-docgen-init branch December 23, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@cristaloleg cristaloleg

Labels
kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristaloleg @Wondertan @renaynay