Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modp2p): Ping and ConnectionState APIs #3989

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat(modp2p): Ping and ConnectionState APIs #3989

merged 3 commits into from
Jan 15, 2025

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Dec 9, 2024 •
edited
Loading

Yet another helpful p2p debugging endpoints with respective commands:

  • Ping tries to reach a peer by its peer id
  • ConnectionState provides information about active connection for a peer by its ID

@Wondertan Wondertan self-assigned this Dec 9, 2024
@Wondertan Wondertan added the kind:feat Attached to feature PRs label Dec 9, 2024
@Wondertan Wondertan force-pushed the modp2p/ping-conn-state branch from 1e3b12e to 0c20304 Compare December 9, 2024 19:03
@Wondertan Wondertan enabled auto-merge (squash) December 9, 2024 19:12
cristaloleg
cristaloleg approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

renaynay
renaynay approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Wondertan Wondertan merged commit e11cd71 into main Jan 15, 2025
24 checks passed
@Wondertan Wondertan deleted the modp2p/ping-conn-state branch January 15, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@Wondertan Wondertan

Labels
area:p2p kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wondertan @cristaloleg @renaynay