perf(shwap/bitswap): add session pools inside Getter #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Robusta enviroment this change: * Improved load distribution across BN/FNs * Sped up sampling Originally, I was testing Bitswap with this change, but decided agaisnt including it in the patch, as its solely an optimization. However, without this change load distribution was rather strange. One LN sampled at 180/s, while all other at 4/s. Adding pools seemed to fix the issue.
Wondertan
requested review from
renaynay,
vgonkivs,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Nov 18, 2024
cristaloleg
reviewed
Nov 18, 2024
cristaloleg
reviewed
Nov 18, 2024
Wondertan
commented
Nov 18, 2024
walldiss
reviewed
Nov 18, 2024
|
I didn't realize that @walldiss is gonna take over that. |
walldiss
previously approved these changes
Nov 18, 2024
walldiss
approved these changes
Nov 18, 2024
vgonkivs
approved these changes
Nov 18, 2024
Wondertan
added a commit
that referenced
this pull request
Nov 18, 2024
In the Robusta environment this change: * Improved load distribution across BN/FNs * Sped up sampling Originally, I was testing Bitswap with this change but decided against including it in the patch, as it is solely an optimization. However, without this change on the rc tag, load distribution was rather strange. One LN sampled at 180/s, while all 4 others at 4/s. Adding pooling fixed the issue and resulted in all 5 LNs at about 100/s. Co-authored-by: Vlad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Robusta environment this change:
Originally, I was testing Bitswap with this change but decided against including it in the patch, as it is solely an optimization. However, without this change on the rc tag, load distribution was rather strange. One LN sampled at 180/s, while all 4 others at 4/s. Adding pooling fixed the issue and resulted in all 5 LNs at about 100/s.