Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodebuilder/pruner: Enforce light pruning #3912

Merged
merged 2 commits into from
Dec 2, 2024
Merged

nodebuilder/pruner: Enforce light pruning #3912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cee020
refactor(nodebuilder/pruner): enforce light pruning
renaynay Nov 1, 2024
c74fde6
Merge branch 'main' into enforce-light-pruning
renaynay Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions nodebuilder/pruner/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,13 @@ func ConstructModule(tp node.Type, cfg *Config) fx.Option {

switch tp {
case node.Light:
if cfg.EnableService {
return fx.Module("prune",
baseComponents,
prunerService,
// TODO(@walldiss @renaynay): remove conversion after Availability and Pruner interfaces are merged
// note this provide exists in pruner module to avoid cyclical imports
fx.Provide(func(la *light.ShareAvailability) pruner.Pruner { return la }),
)
}
// We do not trigger DetectPreviousRun for Light nodes, to allow them to disable pruning at wish.
// They are not expected to store a samples outside the sampling window and so partially pruned is
// not a concern.
// LNs enforce pruning by default
return fx.Module("prune",
baseComponents,
prunerService,
// TODO(@walldiss @renaynay): remove conversion after Availability and Pruner interfaces are merged
// note this provide exists in pruner module to avoid cyclical imports
fx.Provide(func(la *light.ShareAvailability) pruner.Pruner { return la }),
)
case node.Full:
if cfg.EnableService {
Expand Down
Loading