service/header: remove start/stop from P2PExchange #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change config to log warnings with missing trusted peer In HeaderExchangeP2P func we are creating an addr for the host instead of making it in the removed connect Removed store in p2pExchange Co-authored-by: Wondertan <[email protected]>
Bidon15
added
area:config
Wondertan
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change config to log warnings with missing trusted peer
In HeaderExchangeP2P func we are creating an addr for the host instead of making it in the removed connect
Removed store in p2pExchange
Now, instead of handling connection ourselves, we are delegating this to libp2p itself and only creating NewStream in
performRequestfunc inp2p_exchange.goSolves the issue
panic of closing a closed channel#350Co-authored-by: @Wondertan