fix(store/cache): force close Accessor if not closed within timeout #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
walldiss
commented
Aug 8, 2024
•
walldiss
commented
- Force close Accessor if not closed within timeout
close Accessor and log Error if ref was removed by GC instead of user
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
ramin and
cristaloleg
as code owners
Wondertan
previously approved these changes
Aug 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
+ Coverage 44.83% 45.67% +0.83%
==========================================
Files 265 281 +16
Lines 14620 16042 +1422
==========================================
+ Hits 6555 7327 +772
- Misses 7313 7873 +560
- Partials 752 842 +90 ☔ View full report in Codecov by Sentry. |
renaynay
previously approved these changes
Aug 14, 2024
Co-authored-by: rene <[email protected]>
cristaloleg
reviewed
Aug 15, 2024
walldiss
force-pushed
the
improve-refcloser-cache
branch
from
6222b1a
to
d8cb51f
Compare
walldiss
force-pushed
the
improve-refcloser-cache
branch
from
d8cb51f
to
4598bc9
Compare
Wondertan
approved these changes
Aug 19, 2024
vgonkivs
approved these changes
Aug 20, 2024
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 21, 2024
…elestiaorg#3642) (cherry picked from commit 682c2b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.