Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(share): use sync.Once instead of mutex for init #3625

Merged
merged 1 commit into from
Aug 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions share/empty.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,18 @@ func EmptyBlockShares() []Share {
}

var (
emptyMu sync.Mutex
emptyOnce sync.Once
emptyBlockRoot *Root
emptyBlockEDS *rsmt2d.ExtendedDataSquare
emptyBlockShares []Share
)

// initEmpty enables lazy initialization for constant empty block data.
func initEmpty() {
emptyMu.Lock()
defer emptyMu.Unlock()
if emptyBlockRoot != nil {
return
}
emptyOnce.Do(computeEmpty)
}

func computeEmpty() {
// compute empty block EDS and DAH for it
result := shares.TailPaddingShares(appconsts.MinShareCount)
emptyBlockShares = shares.ToBytes(result)
Expand Down
Loading