feat(shwap): Add discovery version #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
ramin and
cristaloleg
as code owners
Wondertan
reviewed
Aug 2, 2024
walldiss
force-pushed
the
add-discovery-version
branch
2 times, most recently
from
29e1a5f to
ea8cef0
Compare
walldiss
force-pushed
the
add-discovery-version
branch
from
ea8cef0 to
6c4541a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3616 +/- ##
========================================
Coverage ? 46.79%
========================================
Files ? 313
Lines ? 17751
Branches ? 0
========================================
Hits ? 8306
Misses ? 8450
Partials ? 995 ☔ View full report in Codecov by Sentry. |
Wondertan
requested changes
Sep 9, 2024
Wondertan
reviewed
Sep 9, 2024
Wondertan
requested changes
Sep 11, 2024
Wondertan
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add versioning for discovery, so we can separate shwap network from older one. Metrics will still use tag instead of topic, so we can support multiple visions with same dashboard