refactor(pruner): reset maxHeadersPerLoop properly #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
vgonkivs
reviewed
Jul 4, 2024
vgonkivs
approved these changes
Jul 4, 2024
renaynay
approved these changes
Jul 4, 2024
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were resetting
maxHeadersPerLoopto a different value (1024) which has no relations to the default value (512). Which isn't that bad because it's a test but still we have a side-effect in theTestPrune_LargeNumberOfBlockstest.Also, changing type of
maxHeadersPerLooptoint'cause in most places we use it as anintand notint64.