Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(header/service): #339 race #343

Merged
merged 2 commits into from
Jan 12, 2022
Merged

fix(header/service): #339 race #343

merged 2 commits into from
Jan 12, 2022

Conversation

Wondertan
Copy link
Member

Quick fix for race
Closes #339

@Wondertan Wondertan self-assigned this Jan 12, 2022
@Wondertan Wondertan requested a review from Bidon15 January 12, 2022 11:06
Bidon15
Bidon15 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Bidon15 Bidon15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 :shipit:

renaynay
renaynay approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

@Wondertan Wondertan merged commit 5c9a036 into main Jan 12, 2022
@Wondertan Wondertan deleted the hlib/fix-race-#339 branch January 12, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bidon15 Bidon15 Bidon15 approved these changes

@renaynay renaynay renaynay approved these changes

@liamsi liamsi Awaiting requested review from liamsi

Assignees

@Wondertan Wondertan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Race Condition in TestCoreListener
3 participants
@Wondertan @Bidon15 @renaynay