fix(blob/service): fix handling of the padding shares #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss and
ramin
as code owners
Wondertan
requested changes
May 15, 2024
walldiss
reviewed
May 16, 2024
vgonkivs
force-pushed
the
fix_missing_blob
branch
from
e6ae531 to
8b3a48d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3404 +/- ##
==========================================
- Coverage 44.83% 44.53% -0.30%
==========================================
Files 265 272 +7
Lines 14620 15282 +662
==========================================
+ Hits 6555 6806 +251
- Misses 7313 7692 +379
- Partials 752 784 +32 ☔ View full report in Codecov by Sentry. |
vgonkivs
force-pushed
the
fix_missing_blob
branch
from
8b3a48d to
309c91b
Compare
walldiss
previously approved these changes
May 16, 2024
renaynay
reviewed
May 16, 2024
|
@renaynay, I propose to make a new patch for this fix, instead of 0.14.0 as its blocking Astria and in general a critical bug. |
Wondertan
previously approved these changes
May 17, 2024
Wondertan
approved these changes
May 17, 2024
walldiss
approved these changes
May 20, 2024
Wondertan
pushed a commit
that referenced
this pull request
May 20, 2024
Fixes the issue with the missing blob. Initially, there was an incorrect assumption that only one padding share is possible between two blobs. So, the Blob service was skipping only one share instead of multiple. * Fixed parsing logic allowing to skip multiple padding shares; * Added a test case that retrieves the EDS and finds the correct number of blobs;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with the missing blob. Initially, there was an incorrect assumption that only one padding share is possible between two blobs. So, the Blob service was skipping only one share instead of multiple.