Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): give a birth to cel-shed and p2p key utilities #281

Merged
merged 4 commits into from
Dec 10, 2021
Merged

feat(cmd): give a birth to cel-shed and p2p key utilities #281

merged 4 commits into from
Dec 10, 2021

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Dec 8, 2021 •
edited
Loading

Start of #276

Tested manually.

@Wondertan Wondertan requested a review from jbowen93 December 8, 2021 22:29
jbowen93
jbowen93 previously approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@jbowen93 jbowen93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

renaynay
renaynay reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm

Makefile Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u were right.

@Wondertan
Copy link
Member Author

I'll change it cel-shed to match Makefile rules

@Wondertan Wondertan dismissed stale reviews from renaynay and jbowen93 via bffa0c6 December 10, 2021 16:00
@Wondertan
Copy link
Member Author

Done

@Wondertan Wondertan requested a review from jbowen93 December 10, 2021 16:00
@Wondertan Wondertan merged commit e1d9290 into main Dec 10, 2021
@Wondertan Wondertan deleted the hlib/cel-shed-key-gen branch December 10, 2021 16:13
Wondertan added a commit that referenced this pull request Dec 15, 2021
@Wondertan
changelog: fix entry position for #281 and #280
aa26784
@Wondertan Wondertan restored the hlib/cel-shed-key-gen branch January 7, 2022 14:40
@Wondertan Wondertan deleted the hlib/cel-shed-key-gen branch January 7, 2022 15:56
Bidon15 pushed a commit to Bidon15/celestia-node that referenced this pull request Jan 11, 2022
@Wondertan @Bidon15
changelog: fix entry position for celestiaorg#281 and celestiaorg#280
10e9b18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi left review comments

@jbowen93 jbowen93 jbowen93 approved these changes

@renaynay renaynay renaynay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wondertan @jbowen93 @liamsi @renaynay