fix(header): temporary disable skipping verification #2449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rene <[email protected]>
Wondertan
requested review from
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
TODO:
|
renaynay
approved these changes
Jul 10, 2023
|
check units |
renaynay
requested changes
Jul 10, 2023
|
I looked up first and saw the flaky PubSub test, but there is one in Verify |
Codecov Report
@@ Coverage Diff @@
## main #2449 +/- ##
==========================================
- Coverage 53.12% 52.98% -0.15%
==========================================
Files 156 156
Lines 9907 9907
==========================================
- Hits 5263 5249 -14
- Misses 4188 4204 +16
+ Partials 456 454 -2
|
renaynay
approved these changes
Jul 11, 2023
vgonkivs
approved these changes
Jul 11, 2023
|
Closing as this PR is stuck. New one here: #2456 |
auto-merge was automatically disabled
July 11, 2023 12:55
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables skipping verification and accepts all the incoming non-adjacent headers. These headers will later be verified via adjacent verification and rejected if invalid.
Test that proves that Syncer rejects and continues to work with a fault header: celestiaorg/go-header#76
Potential outcomes of doing so: celestiaorg/go-header#79
Additionally, the PR reverts the genesis hash change to the hash pointing to height 1.
Supersedes #2443