Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): temporary disable skipping verification #2449

Closed
wants to merge 2 commits into from

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Jul 10, 2023

This PR disables skipping verification and accepts all the incoming non-adjacent headers. These headers will later be verified via adjacent verification and rejected if invalid.

Test that proves that Syncer rejects and continues to work with a fault header: celestiaorg/go-header#76

Potential outcomes of doing so: celestiaorg/go-header#79

Additionally, the PR reverts the genesis hash change to the hash pointing to height 1.

Supersedes #2443

@Wondertan Wondertan added area:header Extended header kind:fix Attached to bug-fixing PRs labels Jul 10, 2023
@Wondertan Wondertan requested a review from renaynay as a code owner July 10, 2023 16:26
@Wondertan Wondertan self-assigned this Jul 10, 2023
@Wondertan
Copy link
Member Author

Wondertan commented Jul 10, 2023

TODO:

  • Issue on the next steps
  • Test sync on mocha

@renaynay
Copy link
Member

check units

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely needs to check verify tests - this breaks one case

@Wondertan
Copy link
Member Author

I looked up first and saw the flaky PubSub test, but there is one in Verify

@Wondertan Wondertan requested a review from renaynay July 10, 2023 17:57
@codecov-commenter
Copy link

Codecov Report

Merging #2449 (efeb25d) into main (eaa5835) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
- Coverage   53.12%   52.98%   -0.15%     
==========================================
  Files         156      156              
  Lines        9907     9907              
==========================================
- Hits         5263     5249      -14     
- Misses       4188     4204      +16     
+ Partials      456      454       -2     
Impacted Files Coverage Δ
nodebuilder/p2p/genesis.go 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

@Wondertan
Copy link
Member Author

Closing as this PR is stuck. New one here: #2456

@Wondertan Wondertan closed this Jul 11, 2023
auto-merge was automatically disabled July 11, 2023 12:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants