Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/header: Implement HeaderExchange #188

Merged
merged 11 commits into from
Nov 17, 2021
Merged

service/header: Implement HeaderExchange #188

merged 11 commits into from
Nov 17, 2021

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Nov 10, 2021 •
edited
Loading

Related to #172.

@renaynay renaynay marked this pull request as ready for review November 11, 2021 14:15
@renaynay renaynay changed the title [DRAFT] service/header: Implement HeaderExchange service/header: Implement HeaderExchange Nov 11, 2021
@renaynay renaynay changed the title service/header: Implement HeaderExchange service/header: Implement HeaderExchange Nov 11, 2021
@evan-forbes evan-forbes mentioned this pull request Nov 12, 2021
Merged
@renaynay renaynay force-pushed the header-exchange branch 2 times, most recently from 7d6ef08 to 584b30d Compare November 12, 2021 21:01
liamsi
liamsi reviewed Nov 12, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

service/header/exchange.go Show resolved Hide resolved
liamsi
liamsi reviewed Nov 12, 2021
View reviewed changes
service/header/exchange.go Outdated Show resolved Hide resolved
liamsi
liamsi reviewed Nov 12, 2021
View reviewed changes
service/header/header.go Outdated Show resolved Hide resolved
liamsi
liamsi reviewed Nov 12, 2021
View reviewed changes
service/header/header.go Outdated Show resolved Hide resolved
liamsi
liamsi reviewed Nov 12, 2021
View reviewed changes
service/header/service.go Outdated Show resolved Hide resolved
liamsi
liamsi previously approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGTM

Wondertan
Wondertan requested changes Nov 14, 2021
View reviewed changes
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange_test.go Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Outdated Show resolved Hide resolved
service/header/exchange.go Show resolved Hide resolved
@liamsi liamsi requested review from Wondertan and liamsi November 15, 2021 10:23
@renaynay renaynay requested a review from Wondertan November 15, 2021 16:05
liamsi
liamsi previously approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀 I'm glad @Wondertan did review this as well and found a bunch of inconsistencies/bugs related to stream lifecycles.

@renaynay renaynay linked an issue Nov 16, 2021 that may be closed by this pull request
ExtendedHeaderExchange -- ability for nodes to request extended headers by height / latest height from their peers via libp2p streams #172
Closed
2 tasks
@renaynay renaynay force-pushed the header-exchange branch 2 times, most recently from 7d9e7ce to 7b90b8c Compare November 16, 2021 10:43
@renaynay renaynay requested a review from liamsi November 16, 2021 10:45
liamsi
liamsi previously approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only got better

@Wondertan
Copy link
Member

We need to rebase on top of the store before we can merge it.

@renaynay renaynay requested a review from liamsi November 17, 2021 13:46
liamsi
liamsi approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@renaynay renaynay merged commit 7cae5c2 into celestiaorg:main Nov 17, 2021
@renaynay renaynay deleted the header-exchange branch November 17, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@Wondertan Wondertan Wondertan approved these changes

@mattdf mattdf Awaiting requested review from mattdf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@renaynay @Wondertan @liamsi