Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @liamsi from global CODEOWNERS #1095

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Remove @liamsi from global CODEOWNERS #1095

merged 1 commit into from
Sep 20, 2022

Conversation

Wondertan
Copy link
Member

Follows recent discussions and celestiaorg/celestia-core#858

@Wondertan Wondertan added admin Related to admin of celestia-node repo kind:misc Attached to miscellaneous PRs labels Sep 14, 2022
@Wondertan Wondertan self-assigned this Sep 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1095 (4d85248) into main (c48c42b) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   56.61%   56.94%   +0.32%     
==========================================
  Files         136      141       +5     
  Lines        9063     9383     +320     
==========================================
+ Hits         5131     5343     +212     
- Misses       3391     3493     +102     
- Partials      541      547       +6     
Impacted Files Coverage Δ
service/rpc/das.go 26.66% <0.00%> (-23.34%) ⬇️
das/daser.go 68.60% <0.00%> (-13.22%) ⬇️
service/state/service.go 27.77% <0.00%> (-7.71%) ⬇️
service/share/testing.go 76.55% <0.00%> (-6.21%) ⬇️
das/state.go 95.45% <0.00%> (-4.55%) ⬇️
header/sync/sync_head.go 57.75% <0.00%> (-1.02%) ⬇️
node/state/core.go 100.00% <0.00%> (ø)
node/state/state.go 100.00% <0.00%> (ø)
service/rpc/state.go 0.00% <0.00%> (ø)
service/rpc/endpoints.go 100.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

distractedm1nd
distractedm1nd previously approved these changes Sep 15, 2022
adlerjohn
adlerjohn previously approved these changes Sep 18, 2022
.github/CODEOWNERS Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@Wondertan Wondertan merged commit 7af2022 into main Sep 20, 2022
@Wondertan Wondertan deleted the hlib/remove-liamse branch September 20, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Related to admin of celestia-node repo kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants