-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: ✍️ added Table of Contents #1082
Conversation
Thank you so much for the contribution @nitinmewar ! Is there any way you can split the two commits contained in this PR into separate PRs? One for returning an error with cel-key and the other for updating table of contents? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Ah I see you've based this PR on #1081 -- no problem! We will just merge that first and then rebase this and merge it :) Thanks @nitinmewar |
@renaynay thanks for giving me chance to contribute. I made two separate branches for these two PRs. can you suggest me what should I do now in order to make them separated PRs. |
@nitinmewar if you implement the suggestion on #1081 , we will merge that first and rebase this PR on top once you've implemented the changes requested here. |
@nitinmewar can you rebase this on main? |
@renaynay yes sure!! |
@renaynay I am trying to rebase my toe branch to main but it is saying branch is up to date. what am I missing? |
git rebase -i upstream/main make sure this repo is set as upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a lint issue @nitinmewar
@renaynay what should I do now? |
from lint error:
|
@nitinmewar, try running |
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
+ Coverage 56.58% 56.61% +0.03%
==========================================
Files 135 136 +1
Lines 8994 9063 +69
==========================================
+ Hits 5089 5131 +42
- Misses 3369 3391 +22
- Partials 536 541 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Still failing |
@Wondertan I will just make an another branch and commit changes to that branch. I think there is some issue with my current branch. should I proceed? |
Yes please @nitinmewar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nitinmewar for starting this and @renaynay, for finishing this
No description provided.