Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: ✍️ added Table of Contents #1082

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

nitinmewar
Copy link
Contributor

No description provided.

@renaynay
Copy link
Member

Thank you so much for the contribution @nitinmewar !

Is there any way you can split the two commits contained in this PR into separate PRs? One for returning an error with cel-key and the other for updating table of contents?

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

cmd/cel-key/node_types.go Outdated Show resolved Hide resolved
@renaynay
Copy link
Member

renaynay commented Sep 13, 2022

Ah I see you've based this PR on #1081 -- no problem! We will just merge that first and then rebase this and merge it :) Thanks @nitinmewar

@nitinmewar
Copy link
Contributor Author

@renaynay thanks for giving me chance to contribute.

I made two separate branches for these two PRs. can you suggest me what should I do now in order to make them separated PRs.

README.md Outdated Show resolved Hide resolved
@renaynay
Copy link
Member

@nitinmewar if you implement the suggestion on #1081 , we will merge that first and rebase this PR on top once you've implemented the changes requested here.

@renaynay
Copy link
Member

@nitinmewar can you rebase this on main?

@renaynay renaynay changed the title ✍️ added Table of Content inside README README: ✍️ added Table of Contents Sep 13, 2022
@renaynay renaynay added kind:misc Attached to miscellaneous PRs documentation Improvements or additions to documentation labels Sep 13, 2022
@nitinmewar
Copy link
Contributor Author

@renaynay yes sure!!

@nitinmewar
Copy link
Contributor Author

@renaynay I am trying to rebase my toe branch to main but it is saying branch is up to date. what am I missing?

@renaynay
Copy link
Member

git rebase -i upstream/main

make sure this repo is set as upstream

renaynay
renaynay previously approved these changes Sep 13, 2022
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a lint issue @nitinmewar

@nitinmewar
Copy link
Contributor Author

@renaynay what should I do now?

@renaynay
Copy link
Member

from lint error:

README.md:37:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:38:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:39:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:58:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:59:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:60:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:78:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:79:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
README.md:80:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
Error: Process completed with exit code 1.

@Wondertan
Copy link
Member

Wondertan commented Sep 14, 2022

@nitinmewar, try running markdownlint --config .markdownlint.yaml '**/*.md' --fix, if it does not fix issues automatically, you should fix them manually

@codecov-commenter
Copy link

Codecov Report

Merging #1082 (1319a45) into main (4618e2b) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
+ Coverage   56.58%   56.61%   +0.03%     
==========================================
  Files         135      136       +1     
  Lines        8994     9063      +69     
==========================================
+ Hits         5089     5131      +42     
- Misses       3369     3391      +22     
- Partials      536      541       +5     
Impacted Files Coverage Δ
fraud/bad_encoding.go 63.00% <0.00%> (-3.00%) ⬇️
node/services/service.go 80.83% <0.00%> (-0.93%) ⬇️
params/network.go 76.92% <0.00%> (ø)
service/state/core_access.go 11.59% <0.00%> (ø)
header/sync/sync_head.go 58.77% <0.00%> (ø)
header/verify.go 82.22% <0.00%> (+0.82%) ⬆️
header/header.go 50.00% <0.00%> (+3.22%) ⬆️
header/sync/sync.go 69.50% <0.00%> (+4.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Wondertan
Copy link
Member

Still failing

@nitinmewar
Copy link
Contributor Author

@Wondertan I will just make an another branch and commit changes to that branch. I think there is some issue with my current branch. should I proceed?

@Wondertan
Copy link
Member

Yes please @nitinmewar

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nitinmewar for starting this and @renaynay, for finishing this

@Wondertan Wondertan merged commit 5dc3e16 into celestiaorg:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kind:misc Attached to miscellaneous PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants