feat(rpc): implementing staking reads and replace sdk.Address #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
liamsi,
renaynay,
Wondertan and
vgonkivs
as code owners
distractedm1nd
added
kind:improvement
and removed
enhancement
walldiss
previously approved these changes
Sep 9, 2022
distractedm1nd
force-pushed
the
staking-reads
branch
from
4f514eb to
fc8d794
Compare
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 56.56% 56.02% -0.54%
==========================================
Files 135 135
Lines 8965 9071 +106
==========================================
+ Hits 5071 5082 +11
- Misses 3359 3454 +95
Partials 535 535
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
reviewed
Sep 12, 2022
renaynay
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Implementation looks clean, thank you @distractedm1nd
Let's please test every endpoint against arabica before we merge. 🙏🏻
distractedm1nd
changed the title
Wondertan
approved these changes
Sep 13, 2022
|
All endpoints including queries have been tested on arabica, BUT:
|
distractedm1nd
added a commit
to renaynay/celestia-node
that referenced
this pull request
Sep 19, 2022
…stiaorg#1060) * feat: staking reads + linting errors * feat: rewriting to not take delAddr as a parameter * refactor(rpc): renaming local variables * refactor(rpc): using AccAddress and ValAddress instead of the generic Address type
distractedm1nd
added a commit
to distractedm1nd/celestia-node
that referenced
this pull request
Sep 21, 2022
…stiaorg#1060) * feat: staking reads + linting errors * feat: rewriting to not take delAddr as a parameter * refactor(rpc): renaming local variables * refactor(rpc): using AccAddress and ValAddress instead of the generic Address type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #986.
Also removes the abstraction of
sdk.Addressto make it explicit that our queries only support their corresponding address type,AccAddressorValAddress