Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Race Condition in TestFull_P2P_Streams #286

Closed
Bidon15 opened this issue Dec 10, 2021 · 0 comments · Fixed by #288
Closed

[Bug]: Race Condition in TestFull_P2P_Streams #286

Bidon15 opened this issue Dec 10, 2021 · 0 comments · Fixed by #288
Labels
bug Something isn't working

Comments

@Bidon15
Copy link
Member

Bidon15 commented Dec 10, 2021

Celestia Node version

a89ef03

OS

Ubuntu 20.04.3 LTS

Install tools

Others

No response

Steps to reproduce it

  1. Make install
  2. go test --race ./...

Expected result

TestFull_P2P_Streams is passing with no race conditions

Actual result

TestFull_P2P_Streams is failing with data races

Relevant log output

https://gist.github.com/Bidon15/9ec686472ed21ee77662fca18dc5ecf2

Notes

We should create a separate GH Action to catch this during every PR

@Bidon15 Bidon15 added the bug Something isn't working label Dec 10, 2021
ynewmann added a commit to ynewmann/celestia-node that referenced this issue Dec 11, 2021
Copy `announce multi addresses` to separate array to avoid data race and return them with `listen multi addresses`.

Issue celestiaorg#286
ynewmann added a commit to ynewmann/celestia-node that referenced this issue Dec 23, 2021
Copy `announce multi addresses` to separate array to avoid data race and return them with `listen multi addresses`.

Issue celestiaorg#286
Bidon15 pushed a commit to Bidon15/celestia-node that referenced this issue Jan 11, 2022
Copy `announce multi addresses` to separate array to avoid data race and return them with `listen multi addresses`.

Issue celestiaorg#286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant