Skip to content

Commit

Permalink
fix(core): don't hold on Data
Browse files Browse the repository at this point in the history
  • Loading branch information
Wondertan committed Nov 8, 2024
1 parent 353141f commit b798cab
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion core/exchange.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"bytes"
"context"
"fmt"
"github.com/tendermint/tendermint/types"
"time"

"golang.org/x/sync/errgroup"
Expand Down Expand Up @@ -177,7 +178,11 @@ func (ce *Exchange) getExtendedHeaderByHeight(ctx context.Context, height *int64
if err != nil {
return nil, fmt.Errorf("extending block data for height %d: %w", b.Header.Height, err)
}
// create extended header

// TODO(@Wondertan): This is a hack to deref Data, allowing GC to pick it up.
// The better footgun-less solution is to change core.ResultSignedBlock fields to be pointers instead of values.
b.Data = types.Data{}

eh, err := ce.construct(&b.Header, &b.Commit, &b.ValidatorSet, eds)
if err != nil {
panic(fmt.Errorf("constructing extended header for height %d: %w", b.Header.Height, err))
Expand Down

0 comments on commit b798cab

Please sign in to comment.