Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stab on removing unused code #208

Merged
merged 7 commits into from
Mar 12, 2021
Merged

First stab on removing unused code #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8780981
First stab on removing unused code (at least by LL)
liamsi Mar 11, 2021
c167a78
remove traces of `install_abci`
liamsi Mar 11, 2021
4363cb1
remove some abci workflows
liamsi Mar 11, 2021
401c20d
remove test_apps workflow completely
liamsi Mar 11, 2021
4e03ca1
only use badger in e2e tests
liamsi Mar 11, 2021
de2d6d8
delete moar
liamsi Mar 11, 2021
c5598c0
change db to badgerdb in default conf and add TODOs about DB + ABCIPr…
liamsi Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 0 additions & 146 deletions .github/workflows/tests.yml
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,18 +115,6 @@ proto-check-breaking-ci:
@$(DOCKER_BUF) check breaking --against-input $(HTTPS_GIT)#branch=master
.PHONY: proto-check-breaking-ci

###############################################################################
### Build ABCI ###
###############################################################################

build_abci:
@go build -mod=readonly -i ./abci/cmd/...
.PHONY: build_abci

install_abci:
@go install -mod=readonly ./abci/cmd/...
.PHONY: install_abci

###############################################################################
### Distribution ###
###############################################################################
Expand Down
25 changes: 1 addition & 24 deletions abci/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,14 @@ package abcicli

import (
"context"
"fmt"

"sync"

"github.com/lazyledger/lazyledger-core/abci/types"
"github.com/lazyledger/lazyledger-core/libs/service"
tmsync "github.com/lazyledger/lazyledger-core/libs/sync"
)

const (
dialRetryIntervalSeconds = 3
echoRetryIntervalSeconds = 1
)

//go:generate mockery --case underscore --name Client

// Client defines an interface for an ABCI client.
Expand Down Expand Up @@ -66,24 +61,6 @@ type Client interface {
PreprocessTxsSync(context.Context, types.RequestPreprocessTxs) (*types.ResponsePreprocessTxs, error)
}

//----------------------------------------

// NewClient returns a new ABCI client of the specified transport type.
// It returns an error if the transport is not "socket" or "grpc"
func NewClient(addr, transport string, mustConnect bool) (client Client, err error) {
switch transport {
case "socket":
client = NewSocketClient(addr, mustConnect)
case "grpc":
client = NewGRPCClient(addr, mustConnect)
default:
err = fmt.Errorf("unknown abci transport %s", transport)
}
return
}

//----------------------------------------

type Callback func(*types.Request, *types.Response)

//----------------------------------------
Expand Down
Loading