test(e2e benchmark): adds network latency

[staheri14]

Closes #3317

[coderabbitai]

Walkthrough

Walkthrough

The changes aim to enhance the e2e benchmark tests by incorporating network latency simulation. This involves enabling BitTwister, setting latency and jitter parameters, forwarding the BitTwister port, updating the manifest structure to include latency settings, and adjusting the throughput function to apply these new parameters effectively.

Changes

File Path	Change Summary
test/e2e/benchmark/benchmark.go	Added logic to enable latency, configure BitTwister parameters, and forward its port. Removed testnet setup logic.
test/e2e/benchmark/manifest.go	Introduced LatencyParams struct and included EnableLatency and LatencyParams fields in the Manifest struct.
test/e2e/benchmark/throughput.go	Updated E2EThroughput function to enable latency simulation with specific parameters.
test/e2e/testnet/node.go	Added ForwardBitTwisterPort method to Node struct for managing BitTwister port forwarding and logging.

Assessment against linked issues

Objective	Addressed	Explanation
Incorporate network delay into sanity (knuu) e2e tests (#3317)	✅
Ensure BitTwister port forwarding and latency settings are correctly applied (#3317)	✅
Validate the addition of latency parameters in the manifest (#3317)	✅
Update throughput tests to reflect new latency settings (#3317)	✅

---

Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cfa4754 and 9e3c437.

Files selected for processing (1)

• test/e2e/benchmark/manifest.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• test/e2e/benchmark/manifest.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.