Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics to prepare and process proposal #2560

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Sep 21, 2023

Closes: #2517

This PR adds metrics to track:

  • The amount of times process proposal recovers from a panic
  • The amount of invalid transactions that get filtered in prepare proposal
  • The time it takes for prepare proposal and process proposal to execute

@celestia-bot celestia-bot requested a review from a team September 21, 2023 14:43
@cmwaters cmwaters self-assigned this Sep 21, 2023
@cmwaters cmwaters added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Sep 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2560 (b96e030) into main (b3fc2df) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2560      +/-   ##
==========================================
- Coverage   20.58%   20.58%   -0.01%     
==========================================
  Files         131      131              
  Lines       15314    15319       +5     
==========================================
  Hits         3153     3153              
- Misses      11858    11863       +5     
  Partials      303      303              
Files Changed Coverage Δ
app/prepare_proposal.go 0.00% <0.00%> (ø)
app/process_proposal.go 0.00% <0.00%> (ø)
app/validate_txs.go 0.00% <0.00%> (ø)

@cmwaters cmwaters merged commit 5682d2c into main Sep 21, 2023
@cmwaters cmwaters deleted the cal/abci-telemetry branch September 21, 2023 15:27
mergify bot pushed a commit that referenced this pull request Sep 21, 2023
Closes: #2517

This PR adds metrics to track:
- The amount of times process proposal recovers from a panic
- The amount of invalid transactions that get filtered in prepare
proposal
- The time it takes for prepare proposal and process proposal to execute

(cherry picked from commit 5682d2c)
evan-forbes pushed a commit that referenced this pull request Sep 22, 2023
…2564)

This is an automatic backport of pull request #2560 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Callum Waters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a metric for filtered txs
4 participants